Skip to content

Conversation

@Gasoonjia
Copy link
Contributor

@Gasoonjia Gasoonjia commented Jan 5, 2026

Stack from ghstack (oldest at bottom):

This diff enables CUDA tensor copy operations in SlimTensor.

Key changes:

core/SlimTensor.h - Extended for CUDA support:

  • Updated copy_() to handle cross-device copies:
    • CPU→CUDA (cudaMemcpyHostToDevice)
    • CUDA→CPU (cudaMemcpyDeviceToHost)
    • CUDA→CUDA (cudaMemcpyDeviceToDevice, same device)
  • Cross-device copies require contiguous tensors
  • CPU-to-CPU copies continue to support non-contiguous (strided) tensors

Differential Revision: D89941235

This diff enables CUDA tensor copy operations in SlimTensor.

**Key changes:**

**`core/SlimTensor.h`** - Extended for CUDA support:
   - Updated `copy_()` to handle cross-device copies:
     - CPU→CUDA (cudaMemcpyHostToDevice)
     - CUDA→CPU (cudaMemcpyDeviceToHost)
     - CUDA→CUDA (cudaMemcpyDeviceToDevice, same device)
   - Cross-device copies require contiguous tensors
   - CPU-to-CPU copies continue to support non-contiguous (strided) tensors

Differential Revision: [D89941235](https://our.internmc.facebook.com/intern/diff/D89941235/)

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Jan 5, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16440

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 131 Pending

As of commit f19ea68 with merge base 35eb01a (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 5, 2026
@github-actions
Copy link

github-actions bot commented Jan 5, 2026

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

This was referenced Jan 5, 2026
This diff enables CUDA tensor copy operations in SlimTensor.

**Key changes:**

**`core/SlimTensor.h`** - Extended for CUDA support:
   - Updated `copy_()` to handle cross-device copies:
     - CPU→CUDA (cudaMemcpyHostToDevice)
     - CUDA→CPU (cudaMemcpyDeviceToHost)
     - CUDA→CUDA (cudaMemcpyDeviceToDevice, same device)
   - Cross-device copies require contiguous tensors
   - CPU-to-CPU copies continue to support non-contiguous (strided) tensors

Differential Revision: [D89941235](https://our.internmc.facebook.com/intern/diff/D89941235/)

[ghstack-poisoned]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants